Re: [PATCH net-next] bnx2: remove deadcode in bnx2_init_cpus()

[Maxim Korotkov]

On 10.03.2023 09:57, Jakub Kicinski wrote:
> On Thu,  9 Mar 2023 20:42:31 +0300 Maxim Korotkov wrote:
> > The load_cpu_fw function has no error return code
> > and always returns zero. Checking the value returned by
> > this function does not make sense.
> > As a result, bnx2_init_cpus() will also return only zero
> > Therefore, it will be safe to change the type of functions
> > to void and remove checking
>
> True, but you need to tell the reader why you're making the change.
> One of the impossible-to-hit error handling paths is missing unwind
> or some such?
 Path with error handling was deleted in 57579f7629a3 ("bnx2: Use 
request_firmware()"). This patch is needed to improving readability.
Now checking the value of the return value is misleading when reading 
the code.
Do I need to add this argument to the patch description?
I also forgot to add mark Reviewed-by: Leon Romanovsky 
<leonro@xxxxxxxxxx> from the previous iteration