Re: [PATCH v1 4/4] arm64: dts: imx93: Add CPU thermal zone

[Alexander Stein]

Hi,

Am Donnerstag, 5. Januar 2023, 11:17:48 CET schrieb Alice Guo (OSS):
> From: Alice Guo <alice.guo@xxxxxxx>
> 
> Add CPU thermal zone and attach it to the TMU which monitors the CPU
> temperature.
> 
> Signed-off-by: Alice Guo <alice.guo@xxxxxxx>
> Reviewed-by: Jacky Bai <ping.bai@xxxxxxx>
> Reviewed-by: Ye Li <ye.li@xxxxxxx>
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 48 ++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi index 6808321ed809..60306f3c5e7f
> 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -8,6 +8,7 @@
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/power/fsl,imx93-power.h>
> +#include <dt-bindings/thermal/thermal.h>
> 
>  #include "imx93-pinfunc.h"
> 
> @@ -116,6 +117,38 @@
>  		interrupt-parent = <&gic>;
>  	};
> 
> +	thermal-zones {
> +		cpu-thermal {
> +			polling-delay-passive = <250>;
> +			polling-delay = <2000>;
> +
> +			thermal-sensors = <&tmu 0>;
> +
> +			trips {
> +				cpu_alert: cpu-alert {
> +					temperature = <80000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				cpu_crit: cpu-crit {
> +					temperature = <90000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +		};

This brace needs an additional indent.

Best regards,
Alexander

> +
> +			cooling-maps {
> +				map0 {
> +					trip = <&cpu_alert>;
> +					cooling-device =
> +						<&A55_0 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +						<&A55_1 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
> +		};
> +	};
> +
>  	soc@0 {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
> @@ -280,6 +313,21 @@
>  				compatible = "fsl,imx93-anatop", 
"syscon";
>  				reg = <0x44480000 0x10000>;
>  			};
> +
> +			tmu: tmu@44482000 {
> +				compatible = "fsl,imx93-tmu";
> +				reg = <0x44482000 0x1000>;
> +				clocks = <&clk IMX93_CLK_TMC_GATE>;
> +				little-endian;
> +				fsl,tmu-calibration = <0x0000000e 
0x800000da
> +						       0x00000029 
0x800000e9
> +						       0x00000056 
0x80000102
> +						       0x000000a2 
0x8000012a
> +						       0x00000116 
0x80000166
> +						       0x00000195 
0x800001a7
> +						       0x000001b2 
0x800001b6>;
> +				#thermal-sensor-cells = <1>;
> +			};
>  		};
> 
>  		aips2: bus@42000000 {


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/