Re: [PATCH v2 1/2] dt-bindings: PWM: Add StarFive PWM module

From: William Qiu
Date: Fri Mar 10 2023 - 03:28:36 EST




On 2023/3/10 16:26, Krzysztof Kozlowski wrote:
> On 10/03/2023 08:45, William Qiu wrote:
>> Add documentation to describe StarFive Pulse Width Modulation
>> controller driver.
>>
>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>
> (...)
>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + pwm@120d0000 {
>> + compatible = "starfive,jh7110-pwm";
>> + reg = <0x120d0000 0x10000>;
>> + clocks = <&syscrg 121>;
>> + resets = <&syscrg 108>;
>> + #pwm-cells=<3>;
>
> Missing spaces around =
>
> With above:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
>
> Best regards,
> Krzysztof
>
Will update.
Thanks for taking time to review this patch series.

Best regards
William