Re: [PATCH v8 00/13] Adds support for PHY LEDs with offload triggers

From: Linus Walleij
Date: Fri Mar 10 2023 - 04:40:32 EST


On Thu, Mar 9, 2023 at 4:22 PM Andrew Lunn <andrew@xxxxxxx> wrote:

> As to 'how a certain trigger on a certain LED is going to associate
> itself with, say, a certain port' is clearly a property of the
> hardware, when offloading is supported. I've not seen a switch you can
> arbitrarily assign LEDs to ports. The Marvell switches have the LED
> registers within the port registers, for example, two LEDs per port.

Aha so there is an implicit HW dependency between the port and the
LED, that we just cannot see in the device tree. Okay, it makes sense.

I think there will be a day when a switch without LED controller appears,
but the system has a few LEDs for the ports connected to an
arbitrary GPIO controller, and then we will need this. But we have
not seen that yet :)

Yours,
Linus Walleij