Re: [PATCH v1 1/1] remoteproc: qcom: pas: Coredump elf class to elf64

From: Dmitry Baryshkov
Date: Fri Mar 10 2023 - 07:16:50 EST


On 10/03/2023 06:04, Sibi Sankar wrote:
Hey Gokul,

Thanks for the patch.

On 3/9/23 05:40, Gokul krishna Krishnakumar wrote:
This change adds a new initialization param which modifies the elf
class accordingly. Some of the subsystem dump analysis tools need
the elf class to be elf64.


https://lore.kernel.org/lkml/8dea333d-544d-7c07-d560-a1a9c3a38ddc@xxxxxxxxxxx/

This patch was already sent upstream a while back ^^. IIRC the firmware
certainly aren't 64 bit elfs and dump analysis tools don't really care as long the coredump contains section headers.

I think that if we want to change the coredump ELF class, we should match the class of the loaded firmware file. Same applies to the ELF machine (EM_NONE).

--
With best wishes
Dmitry