Re: [PATCH] mmc: arasan: Use of_property_present() for testing DT property presence

[Ulf Hansson]

On Fri, 10 Mar 2023 at 15:47, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 89c431a34c43..415f44bf5ee6 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1434,7 +1434,7 @@ static void sdhci_arasan_unregister_sdclk(struct device *dev)
>  {
>         struct device_node *np = dev->of_node;
>
> -       if (!of_find_property(np, "#clock-cells", NULL))
> +       if (!of_property_present(np, "#clock-cells"))
>                 return;
>
>         of_clk_del_provider(dev->of_node);
> --
> 2.39.2
>