Re: [PATCH] x86/hyperv: Mark hv_ghcb_terminate() as noreturn

From: Guilherme G. Piccoli
Date: Fri Mar 10 2023 - 10:50:21 EST


On 10/03/2023 12:24, Josh Poimboeuf wrote:
> On Fri, Mar 10, 2023 at 11:02:52AM -0300, Guilherme G. Piccoli wrote:
> I'd recommend also adding it to the objtool global_noreturns list,
> otherwise this patch will probably trigger warnings with other non-IBT
> configs, in cases where the function is called from another translation
> unit, where GCC knows the function is noreturn but objtool doesn't.
>
> We're looking at ways of eliminating global_noreturns, but it's
> unfortunately still a necessary evil at this point.
>

Hi Josh, thanks! Makes sense, I'll respond here with a V2 doing that.


> Also, FWIW, I have a change coming soon which make these warnings much
> easier to diagnose.
>

Cool =)