Re: [RFC PATCH V3 16/16] x86/sev: Fix interrupt exit code paths from #HV exception

From: Tianyu Lan
Date: Fri Mar 10 2023 - 11:06:11 EST


On 2/22/2023 12:44 AM, Gupta, Pankaj wrote:
@@ -2529,3 +2537,25 @@ static int __init snp_init_platform_device(void)
      return 0;
  }
  device_initcall(snp_init_platform_device);
+
+noinstr void irqentry_exit_hv_cond(struct pt_regs *regs, irqentry_state_t state)
+{

This code path is being called even for the guest without SNP. Ran
a SEV guest and guest crashed in this code path. Checking & returning
made guest (non SNP) to boot with some call traces. But this branch needs to be avoided for non-SNP guests and host as well.


Nice catch! I will fix it in the next version.

Thanks.