Re: [PATCH] iommu: omap: Use of_property_read_bool() for boolean properties

[Robin Murphy]

On 2023-03-10 14:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().

Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>

> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>   drivers/iommu/omap-iommu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 3ab078112a7c..baafd6211ac4 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1191,7 +1191,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
>   		return err;
>   	if (obj->nr_tlb_entries != 32 && obj->nr_tlb_entries != 8)
>   		return -EINVAL;
> -	if (of_find_property(of, "ti,iommu-bus-err-back", NULL))
> +	if (of_property_read_bool(of, "ti,iommu-bus-err-back"))
>   		obj->has_bus_err_back = MMU_GP_REG_BUS_ERR_BACK_EN;
>   
>   	obj->dev = &pdev->dev;