Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

From: Neil Armstrong
Date: Fri Mar 10 2023 - 11:59:21 EST


Hi,

On 10/03/2023 14:21, Jianhua Lu wrote:
Add a driver for panels using the Novatek NT36523 display driver IC.

Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
---
Changes in v4:
- add multiple modes support
- use dev_err_probe helper
- fix dsi_info type string
- reimplement mipi_dsi_dual_dcs_write_seq() macro

Changes in v3:
- Refactor source code

Changes in v2:
- Refactor and clean up source code

MAINTAINERS | 7 +
drivers/gpu/drm/panel/Kconfig | 10 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-novatek-nt36523.c | 771 ++++++++++++++++++
4 files changed, 789 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36523.c


<snip>

It looks great now, Konrad do you have some comments on this revision ?

Neil