Re: [PATCH] power: reset: qcom-pon: drop of_match_ptr for ID table

From: Konrad Dybcio
Date: Fri Mar 10 2023 - 15:11:09 EST




On 10.03.2023 21:06, Krzysztof Kozlowski wrote:
> The Qualcomm SoC power-on driver is specific to ARCH_QCOM which depends
> on OF thus the driver is OF-only. It's of_device_id table is built
> unconditionally, thus of_match_ptr() for ID table does not make sense.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> drivers/power/reset/qcom-pon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 16bc01738be9..ebdcfb28c4a0 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -91,7 +91,7 @@ static struct platform_driver pm8916_pon_driver = {
> .probe = pm8916_pon_probe,
> .driver = {
> .name = "pm8916-pon",
> - .of_match_table = of_match_ptr(pm8916_pon_id_table),
> + .of_match_table = pm8916_pon_id_table,
> },
> };
> module_platform_driver(pm8916_pon_driver);