Re: [PATCH 3/4] pwm: iqs620a: Explicitly set .polarity in .get_state()

From: Jeff LaBundy
Date: Fri Mar 10 2023 - 18:29:24 EST


On Fri, Mar 10, 2023 at 07:48:15PM +0100, Uwe Kleine-König wrote:
> [To += Jeff LaBundy]
>
> On Tue, Feb 28, 2023 at 02:55:07PM +0100, Uwe Kleine-König wrote:
> > The driver only supports normal polarity. Complete the implementation of
> > .get_state() by setting .polarity accordingly.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> I think we should apply this patch as a fix to prevent similar failures
> as reported for the meson driver. To justify that:
>
> Fixes: 6f0841a8197b ("pwm: Add support for Azoteq IQS620A PWM generator")

Reviewed-by: Jeff LaBundy <jeff@xxxxxxxxxxx>

>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |