Re: [PATCH v4 0/3] security: Always enable integrity LSM

From: Paul Moore
Date: Fri Mar 10 2023 - 18:38:07 EST


On Fri, Mar 10, 2023 at 3:54 AM Roberto Sassu
<roberto.sassu@xxxxxxxxxxxxxxx> wrote:
>
> From: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
>
> Since the integrity (including IMA and EVM) functions are currently always
> called by the LSM infrastructure, and always after all LSMs, formalize
> these requirements by introducing a new LSM ordering called LSM_ORDER_LAST,
> and set it for the 'integrity' LSM (patch 1).
>
> Consequently, revert commit 92063f3ca73a ("integrity: double check
> iint_cache was initialized"), as the double check becomes always verified
> (patch 2), and remove 'integrity' from the list of LSMs in
> security/Kconfig (patch 3).
>
> Changelog
>
> v3:
> - Remove Signed-off-by tag by Mimi (suggested by Paul)
> - Clarify that an LSM with order LSM_ORDER_FIRST or LSM_ORDER_LAST is
> always enabled if it is selected in the kernel configuration (suggested
> by Paul)
>
> v2:
> - Fix commit message in patch 1 (suggested by Mimi)
> - Bump version of patch 2 (v1 -> v3) to make one patch set
> - Add patch 3 (suggested by Mimi)
>
> v1:
> - Add comment for LSM_ORDER_LAST definition (suggested by Mimi)
> - Add Fixes tag (suggested by Mimi)
> - Do minor corrections in the commit messages (suggested by Mimi and
> Stefan)
>
> Roberto Sassu (3):
> security: Introduce LSM_ORDER_LAST and set it for the integrity LSM
> Revert "integrity: double check iint_cache was initialized"
> security: Remove integrity from the LSM list in Kconfig
>
> include/linux/lsm_hooks.h | 1 +
> security/Kconfig | 16 +++++++++-------
> security/integrity/iint.c | 9 +--------
> security/security.c | 12 +++++++++---
> 4 files changed, 20 insertions(+), 18 deletions(-)

I just merged the full patchset into the lsm/next branch, thanks everyone!

--
paul-moore.com