Re: [PATCH] soc: qcom: gsbi: mark OF related data as maybe unused

From: Konrad Dybcio
Date: Fri Mar 10 2023 - 19:05:00 EST




On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Shouldn't this driver depend on OF?

Konrad
> drivers/soc/qcom/qcom_gsbi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> index 290bdefbf28a..f1742e5bddb9 100644
> --- a/drivers/soc/qcom/qcom_gsbi.c
> +++ b/drivers/soc/qcom/qcom_gsbi.c
> @@ -114,7 +114,7 @@ struct gsbi_info {
> struct regmap *tcsr;
> };
>
> -static const struct of_device_id tcsr_dt_match[] = {
> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
> { .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
> { .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
> { .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},