[PATCH v2 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups
From: Sean Christopherson
Date: Fri Mar 10 2023 - 19:23:18 EST
Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's
page-track APIs to provide a leaner and cleaner interface. The motivation
for this series is to (significantly) reduce the number of KVM APIs that
KVMGT uses, with a long-term goal of making all kvm_host.h headers
KVM-internal.
As was the case in v1, tThe KVMGT changes are compile tested only.
Based on "git://git.kernel.org/pub/scm/virt/kvm/kvm.git next".
v2:
- Reuse vgpu_lock to protect gfn hash instead of introducing a new (and
buggy) mutext. [Yan]
- Remove a spurious return from kvm_page_track_init(). [Yan]
- Take @kvm directly in the inner __kvm_page_track_write(). [Yan]
- Delete the gfn sanity check that relies on kvm_is_visible_gfn() instead
of providing a dedicated interface. [Yan]
v1: https://lore.kernel.org/lkml/20221223005739.1295925-1-seanjc@xxxxxxxxxx
Sean Christopherson (23):
drm/i915/gvt: Verify pfn is "valid" before dereferencing "struct page"
KVM: x86/mmu: Factor out helper to get max mapping size of a memslot
drm/i915/gvt: Incorporate KVM memslot info into check for 2MiB GTT
entry
drm/i915/gvt: Verify VFIO-pinned page is THP when shadowing 2M gtt
entry
drm/i915/gvt: Put the page reference obtained by KVM's gfn_to_pfn()
drm/i915/gvt: Don't rely on KVM's gfn_to_pfn() to query possible 2M
GTT
drm/i915/gvt: Use an "unsigned long" to iterate over memslot gfns
drm/i915/gvt: Drop unused helper intel_vgpu_reset_gtt()
drm/i915/gvt: Protect gfn hash table with vgpu_lock
KVM: x86/mmu: Don't rely on page-track mechanism to flush on memslot
change
KVM: x86/mmu: Don't bounce through page-track mechanism for guest PTEs
KVM: drm/i915/gvt: Drop @vcpu from KVM's ->track_write() hook
KVM: x86: Reject memslot MOVE operations if KVMGT is attached
drm/i915/gvt: Don't bother removing write-protection on to-be-deleted
slot
KVM: x86/mmu: Move KVM-only page-track declarations to internal header
KVM: x86/mmu: Use page-track notifiers iff there are external users
KVM: x86/mmu: Drop infrastructure for multiple page-track modes
KVM: x86/mmu: Rename page-track APIs to reflect the new reality
KVM: x86/mmu: Assert that correct locks are held for page
write-tracking
KVM: x86/mmu: Bug the VM if write-tracking is used but not enabled
KVM: x86/mmu: Drop @slot param from exported/external page-track APIs
KVM: x86/mmu: Handle KVM bookkeeping in page-track APIs, not callers
drm/i915/gvt: Drop final dependencies on KVM internal details
Yan Zhao (4):
drm/i915/gvt: remove interface intel_gvt_is_valid_gfn
KVM: x86: Add a new page-track hook to handle memslot deletion
drm/i915/gvt: switch from ->track_flush_slot() to
->track_remove_region()
KVM: x86: Remove the unused page-track hook track_flush_slot()
arch/x86/include/asm/kvm_host.h | 16 +-
arch/x86/include/asm/kvm_page_track.h | 66 +++----
arch/x86/kvm/mmu.h | 2 +
arch/x86/kvm/mmu/mmu.c | 61 +++---
arch/x86/kvm/mmu/mmu_internal.h | 2 +
arch/x86/kvm/mmu/page_track.c | 270 ++++++++++++++------------
arch/x86/kvm/mmu/page_track.h | 58 ++++++
arch/x86/kvm/x86.c | 13 +-
drivers/gpu/drm/i915/gvt/gtt.c | 88 ++-------
drivers/gpu/drm/i915/gvt/gtt.h | 1 -
drivers/gpu/drm/i915/gvt/gvt.h | 3 +-
drivers/gpu/drm/i915/gvt/kvmgt.c | 132 ++++++-------
drivers/gpu/drm/i915/gvt/page_track.c | 10 +-
13 files changed, 361 insertions(+), 361 deletions(-)
create mode 100644 arch/x86/kvm/mmu/page_track.h
base-commit: 45dd9bc75d9adc9483f0c7d662ba6e73ed698a0b
--
2.40.0.rc1.284.g88254d51c5-goog