Re: [PATCH] staging: sm750: Rename camel case functions in sm750_cursor.*
From: kernel test robot
Date: Fri Mar 10 2023 - 20:06:45 EST
Hi Kloudifold,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Kloudifold/staging-sm750-Rename-camel-case-functions-in-sm750_cursor/20230311-053447
patch link: https://lore.kernel.org/r/ZAuiDTDT8dmBcRoH%40CloudiRingWorld
patch subject: [PATCH] staging: sm750: Rename camel case functions in sm750_cursor.*
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230311/202303110849.X24WnHnM-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/c82f66fbd5902ae486c4e2227e5071a59c49a05a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kloudifold/staging-sm750-Rename-camel-case-functions-in-sm750_cursor/20230311-053447
git checkout c82f66fbd5902ae486c4e2227e5071a59c49a05a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/staging/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/staging/sm750fb/sm750.c: In function 'lynxfb_ops_cursor':
>> drivers/staging/sm750fb/sm750.c:124:17: error: implicit declaration of function 'sm750_hw_cursor_setSize'; did you mean 'sm750_hw_cursor_set_size'? [-Werror=implicit-function-declaration]
124 | sm750_hw_cursor_setSize(cursor,
| ^~~~~~~~~~~~~~~~~~~~~~~
| sm750_hw_cursor_set_size
>> drivers/staging/sm750fb/sm750.c:129:17: error: implicit declaration of function 'sm750_hw_cursor_setPos'; did you mean 'sm750_hw_cursor_set_pos'? [-Werror=implicit-function-declaration]
129 | sm750_hw_cursor_setPos(cursor,
| ^~~~~~~~~~~~~~~~~~~~~~
| sm750_hw_cursor_set_pos
>> drivers/staging/sm750fb/sm750.c:145:17: error: implicit declaration of function 'sm750_hw_cursor_setColor'; did you mean 'sm750_hw_cursor_set_color'? [-Werror=implicit-function-declaration]
145 | sm750_hw_cursor_setColor(cursor, fg, bg);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| sm750_hw_cursor_set_color
>> drivers/staging/sm750fb/sm750.c:149:17: error: implicit declaration of function 'sm750_hw_cursor_setData'; did you mean 'sm750_hw_cursor_set_data'? [-Werror=implicit-function-declaration]
149 | sm750_hw_cursor_setData(cursor,
| ^~~~~~~~~~~~~~~~~~~~~~~
| sm750_hw_cursor_set_data
cc1: some warnings being treated as errors
vim +124 drivers/staging/sm750fb/sm750.c
81dee67e215b23 Sudip Mukherjee 2015-03-03 104
81dee67e215b23 Sudip Mukherjee 2015-03-03 105 /* no hardware cursor supported under version 2.6.10, kernel bug */
81dee67e215b23 Sudip Mukherjee 2015-03-03 106 static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)
81dee67e215b23 Sudip Mukherjee 2015-03-03 107 {
81dee67e215b23 Sudip Mukherjee 2015-03-03 108 struct lynxfb_par *par;
81dee67e215b23 Sudip Mukherjee 2015-03-03 109 struct lynxfb_crtc *crtc;
81dee67e215b23 Sudip Mukherjee 2015-03-03 110 struct lynx_cursor *cursor;
81dee67e215b23 Sudip Mukherjee 2015-03-03 111
81dee67e215b23 Sudip Mukherjee 2015-03-03 112 par = info->par;
81dee67e215b23 Sudip Mukherjee 2015-03-03 113 crtc = &par->crtc;
81dee67e215b23 Sudip Mukherjee 2015-03-03 114 cursor = &crtc->cursor;
81dee67e215b23 Sudip Mukherjee 2015-03-03 115
39f9137268ee3d Benjamin Philip 2021-07-26 116 if (fbcursor->image.width > cursor->max_w ||
cfdafb7608b4cf Benjamin Philip 2021-07-26 117 fbcursor->image.height > cursor->max_h ||
81dee67e215b23 Sudip Mukherjee 2015-03-03 118 fbcursor->image.depth > 1) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 119 return -ENXIO;
81dee67e215b23 Sudip Mukherjee 2015-03-03 120 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 121
52d0744d751d8f Arnd Bergmann 2016-11-09 122 sm750_hw_cursor_disable(cursor);
f46a04c75605fd Michel von Czettritz 2015-03-27 123 if (fbcursor->set & FB_CUR_SETSIZE)
52d0744d751d8f Arnd Bergmann 2016-11-09 @124 sm750_hw_cursor_setSize(cursor,
3318bb5e945f70 Michel von Czettritz 2015-03-26 125 fbcursor->image.width,
3318bb5e945f70 Michel von Czettritz 2015-03-26 126 fbcursor->image.height);
81dee67e215b23 Sudip Mukherjee 2015-03-03 127
3318bb5e945f70 Michel von Czettritz 2015-03-26 128 if (fbcursor->set & FB_CUR_SETPOS)
52d0744d751d8f Arnd Bergmann 2016-11-09 @129 sm750_hw_cursor_setPos(cursor,
3318bb5e945f70 Michel von Czettritz 2015-03-26 130 fbcursor->image.dx - info->var.xoffset,
81dee67e215b23 Sudip Mukherjee 2015-03-03 131 fbcursor->image.dy - info->var.yoffset);
81dee67e215b23 Sudip Mukherjee 2015-03-03 132
81dee67e215b23 Sudip Mukherjee 2015-03-03 133 if (fbcursor->set & FB_CUR_SETCMAP) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 134 /* get the 16bit color of kernel means */
81dee67e215b23 Sudip Mukherjee 2015-03-03 135 u16 fg, bg;
876e5a701f17e4 Michel von Czettritz 2015-03-26 136
81dee67e215b23 Sudip Mukherjee 2015-03-03 137 fg = ((info->cmap.red[fbcursor->image.fg_color] & 0xf800)) |
81dee67e215b23 Sudip Mukherjee 2015-03-03 138 ((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> 5) |
81dee67e215b23 Sudip Mukherjee 2015-03-03 139 ((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> 11);
81dee67e215b23 Sudip Mukherjee 2015-03-03 140
81dee67e215b23 Sudip Mukherjee 2015-03-03 141 bg = ((info->cmap.red[fbcursor->image.bg_color] & 0xf800)) |
81dee67e215b23 Sudip Mukherjee 2015-03-03 142 ((info->cmap.green[fbcursor->image.bg_color] & 0xfc00) >> 5) |
81dee67e215b23 Sudip Mukherjee 2015-03-03 143 ((info->cmap.blue[fbcursor->image.bg_color] & 0xf800) >> 11);
81dee67e215b23 Sudip Mukherjee 2015-03-03 144
52d0744d751d8f Arnd Bergmann 2016-11-09 @145 sm750_hw_cursor_setColor(cursor, fg, bg);
81dee67e215b23 Sudip Mukherjee 2015-03-03 146 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 147
70407df77665c0 Michel von Czettritz 2015-03-26 148 if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) {
52d0744d751d8f Arnd Bergmann 2016-11-09 @149 sm750_hw_cursor_setData(cursor,
81dee67e215b23 Sudip Mukherjee 2015-03-03 150 fbcursor->rop,
81dee67e215b23 Sudip Mukherjee 2015-03-03 151 fbcursor->image.data,
81dee67e215b23 Sudip Mukherjee 2015-03-03 152 fbcursor->mask);
81dee67e215b23 Sudip Mukherjee 2015-03-03 153 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 154
f46a04c75605fd Michel von Czettritz 2015-03-27 155 if (fbcursor->enable)
52d0744d751d8f Arnd Bergmann 2016-11-09 156 sm750_hw_cursor_enable(cursor);
81dee67e215b23 Sudip Mukherjee 2015-03-03 157
81dee67e215b23 Sudip Mukherjee 2015-03-03 158 return 0;
81dee67e215b23 Sudip Mukherjee 2015-03-03 159 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 160
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests