Re: [PATCH] gpio: Use of_property_read_bool() for boolean properties

From: Rob Herring
Date: Fri Mar 10 2023 - 22:00:41 EST


On Fri, Mar 10, 2023 at 4:41 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Fri, Mar 10, 2023 at 3:47 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> > It is preferred to use typed property access functions (i.e.
> > of_property_read_<type> functions) rather than low-level
> > of_get_property/of_find_property functions for reading properties.
> > Convert reading boolean properties to to of_property_read_bool().
> >
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> You are using of_property_present() rather than of_property_read_bool()
> but I'm not picky about commit message details.

ugg, well, it's the commit message that's correct. I missed updating
this one to use of_property_read_bool().

Rob

> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Yours,
> Linus Walleij