Re: [PATCH v14 05/12] x86/smpboot: Split up native_cpu_up into separate phases and document them

[Thomas Gleixner]

On Wed, Mar 08 2023 at 17:13, Usama Arif wrote:
>  
> +int native_cpu_up(unsigned int cpu, struct task_struct *tidle)
> +{
> +	int ret;
> +
> +	ret = do_cpu_up(cpu, tidle);
> +	if (ret)
> +		return ret;

In case of error this leaves the warm reset vector dangling.

> +	ret = do_wait_cpu_initialized(cpu);
> +	if (ret)
> +		return ret;
> +
> +	ret = do_wait_cpu_callin(cpu);
> +	if (ret)
> +		return ret;

Same for these two error returns.

Thanks,

        tglx