Re: [PATCH 5.4 000/357] 5.4.235-rc1 review

From: Sudip Mukherjee
Date: Sat Mar 11 2023 - 07:25:00 EST


Hi Greg,

On Fri, Mar 10, 2023 at 02:34:49PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.235 release.
> There are 357 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 12 Mar 2023 13:36:38 +0000.
> Anything received after that time might be too late.

Build test (gcc version 11.3.1 20230210):
mips: 65 configs -> 1 failure
arm: 106 configs -> no failure
arm64: 2 configs -> no failure
x86_64: 4 configs -> no failure
alpha allmodconfig -> no failure
powerpc allmodconfig -> no failure
riscv allmodconfig -> no failure
s390 allmodconfig -> failed
xtensa allmodconfig -> no failure

Note:
mips build failed with the error:

arch/mips/lasat/picvue_proc.c:42:44: error: expected ')' before '&' token
42 | static DECLARE_TASKLET(pvc_display_tasklet, &pvc_display, 0);
| ^~
| )
arch/mips/lasat/picvue_proc.c: In function 'pvc_line_proc_write':
arch/mips/lasat/picvue_proc.c:87:27: error: 'pvc_display_tasklet' undeclared (first use in this function)
87 | tasklet_schedule(&pvc_display_tasklet);
| ^~~~~~~~~~~~~~~~~~~
arch/mips/lasat/picvue_proc.c:87:27: note: each undeclared identifier is reported only once for each function it appears in
At top level:
arch/mips/lasat/picvue_proc.c:33:13: error: 'pvc_display' defined but not used [-Werror=unused-function]
33 | static void pvc_display(unsigned long data)
| ^~~~~~~~~~~


s390 build failed with:

drivers/s390/block/dasd_diag.c:658:23: error: initialization of 'int (*)(struct dasd_device *, __u8)' {aka 'int (*)(struct dasd_device *, unsigned char)'} from incompatible pointer type 'int (*)(struct dasd_device *, __u8, __u8)' {aka 'int (*)(struct dasd_device *, unsigned char, unsigned char)'} [-Werror=incompatible-pointer-types]
658 | .pe_handler = dasd_diag_pe_handler,
| ^~~~~~~~~~~~~~~~~~~~
drivers/s390/block/dasd_diag.c:658:23: note: (near initialization for 'dasd_diag_discipline.pe_handler')

Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]

[1]. https://openqa.qa.codethink.co.uk/tests/3081


Tested-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>

--
Regards
Sudip