Re: [PATCH] Fix buffer overrun in HID-SENSOR name.

From: Jonathan Cameron
Date: Sat Mar 11 2023 - 07:31:58 EST


On Sat, 11 Mar 2023 01:53:22 +0100
Philipp Jungkamp <p.jungkamp@xxxxxxx> wrote:

> This is exactly the fix I proposed. Thank you for testing and properly
> submitting it.
>
> Regards,
> Philipp Jungkamp

Looks good to me as well.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

>
> On Fri, 2023-03-10 at 15:54 -0800, Todd Brandt wrote:
> > Philipp Jungkamp created this fix, I'm simply submitting it. I've
> > verified it fixes bugzilla issue 217169.
> >
> > Reported-and-tested-by: Todd Brandt <todd.e.brandt@xxxxxxxxxxxxxxx>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217169
> > Signed-off-by: Todd Brandt <todd.e.brandt@xxxxxxxxx>
> > ---
> >  drivers/hid/hid-sensor-custom.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-
> > sensor-custom.c
> > index 3e3f89e01d81..d85398721659 100644
> > --- a/drivers/hid/hid-sensor-custom.c
> > +++ b/drivers/hid/hid-sensor-custom.c
> > @@ -940,7 +940,7 @@ hid_sensor_register_platform_device(struct
> > platform_device *pdev,
> >                                     struct hid_sensor_hub_device
> > *hsdev,
> >                                     const struct
> > hid_sensor_custom_match *match)
> >  {
> > -       char real_usage[HID_SENSOR_USAGE_LENGTH];
> > +       char real_usage[HID_SENSOR_USAGE_LENGTH] = { 0 };
> >         struct platform_device *custom_pdev;
> >         const char *dev_name;
> >         char *c;
>