[PATCH] wifi: cfg80211: Partial revert "wifi: cfg80211: Fix use after free for wext"

From: Hector Martin
Date: Sat Mar 11 2023 - 09:21:47 EST


This reverts part of commit 015b8cc5e7c4 ("wifi: cfg80211: Fix use after
free for wext")

This commit broke WPA offload by unconditionally clearing the crypto
modes for non-WEP connections. Drop that part of the patch.

Fixes: 015b8cc5e7c4 ("wifi: cfg80211: Fix use after free for wext")
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/linux-wireless/ZAx0TWRBlGfv7pNl@xxxxxxxxx/T/#m11e6e0915ab8fa19ce8bc9695ab288c0fe018edf
Signed-off-by: Hector Martin <marcan@xxxxxxxxx>
---
net/wireless/sme.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 28ce13840a88..7bdeb8eea92d 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -1500,8 +1500,6 @@ int cfg80211_connect(struct cfg80211_registered_device *rdev,
connect->key = NULL;
connect->key_len = 0;
connect->key_idx = 0;
- connect->crypto.cipher_group = 0;
- connect->crypto.n_ciphers_pairwise = 0;
}

wdev->connect_keys = connkeys;
--
2.35.1