Re: [PATCH v2] iio: dac: cio-dac: Migrate to the regmap API

[William Breathitt Gray]

On Sat, Mar 11, 2023 at 06:57:19PM +0000, Jonathan Cameron wrote:
> On Sat, 11 Mar 2023 09:02:18 -0500
> William Breathitt Gray <william.gray@xxxxxxxxxx> wrote:
> > diff --git a/drivers/iio/dac/cio-dac.c b/drivers/iio/dac/cio-dac.c
> > index 791dd999cf29..759833a6bd29 100644
> > --- a/drivers/iio/dac/cio-dac.c
> > +++ b/drivers/iio/dac/cio-dac.c
> > @@ -6,16 +6,15 @@
> >   * This driver supports the following Measurement Computing devices: CIO-DAC16,
> >   * CIO-DAC06, and PC104-DAC06.
> >   */
> > -#include <linux/bitops.h>
> > +#include <linux/bits.h>
> 
> I'm not immediately spotting why this change is part of the regmap
> conversion.
> 
> It may well make sense, but if unrelated, should probably be in a different patch.

No you're right, this is an unrelated cleanup that I should probably
have pulled out to its own dedicated patch. If there is a need for a v3,
I'll split this off and submit it separately.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature