Re: [PATCH net-next] net: introduce budget_squeeze to help us tune rx behavior

From: Jason Xing
Date: Sat Mar 11 2023 - 19:05:08 EST


On Sun, Mar 12, 2023 at 1:14 AM Stephen Hemminger
<stephen@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, 12 Mar 2023 00:36:14 +0800
> Jason Xing <kerneljasonxing@xxxxxxxxx> wrote:
>
> > - for (;;) {
> > + for (; is_continue;) {
>
>
> Easier to read this as a
> while (is_continue) {
>
> but what is wrong with using break; instead?

If we hit the budget limit and 'break;' immediately, we may miss the
collection when we also hit the time limit. That's why I would like to
know if we hit both of them.

Thank,
Jason