RE: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID table

[Hennerich, Michael]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Samstag, 11. März 2023 18:33
> To: Andrew Lunn <andrew@xxxxxxx>; Florian Fainelli <f.fainelli@xxxxxxxxx>;
> Vladimir Oltean <olteanv@xxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Hauke
> Mehrtens <hauke@xxxxxxxxxx>; Woojung Huh
> <woojung.huh@xxxxxxxxxxxxx>; UNGLinuxDriver@xxxxxxxxxxxxx; Claudiu
> Manoil <claudiu.manoil@xxxxxxx>; Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxx>; Colin Foster <colin.foster@in-
> advantage.com>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>;
> Alexander Aring <alex.aring@xxxxxxxxx>; Stefan Schmidt
> <stefan@xxxxxxxxxxxxxxxxxx>; Miquel Raynal <miquel.raynal@xxxxxxxxxxx>;
> Heiner Kallweit <hkallweit1@xxxxxxxxx>; Russell King
> <linux@xxxxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-wpan@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 07/12] net: ieee802154: adf7242: drop of_match_ptr for ID
> table
> 
> The driver will match mostly by DT table (even thought there is regular ID
> table) so there is little benefit in of_match_ptr (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
> 
>   drivers/net/ieee802154/adf7242.c:1322:34: error: ‘adf7242_of_match’
> defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/net/ieee802154/adf7242.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/adf7242.c
> b/drivers/net/ieee802154/adf7242.c
> index 5cf218c674a5..509acc86001c 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -1336,7 +1336,7 @@ MODULE_DEVICE_TABLE(spi, adf7242_device_id);
> static struct spi_driver adf7242_driver = {
>  	.id_table = adf7242_device_id,
>  	.driver = {
> -		   .of_match_table = of_match_ptr(adf7242_of_match),
> +		   .of_match_table = adf7242_of_match,
>  		   .name = "adf7242",
>  		   .owner = THIS_MODULE,
>  		   },
> --
> 2.34.1