Re: [PATCH] staging: greybus: eclose macro in a do - while loop

[Menna Mahmoud]

On ١١‏/٣‏/٢٠٢٣ ١٧:٠٠, Julia Lawall wrote:
> On Sat, 11 Mar 2023, Menna Mahmoud wrote:
>
> > On ١١/٣/٢٠٢٣ ١٦:٠٦, Dan Carpenter wrote:
> > > On Sat, Mar 11, 2023 at 03:59:19PM +0200, Menna Mahmoud wrote:
> > > > " ERROR: Macros with multiple statements should be enclosed in a do -
> > > > while loop"
> > > >
> > > > Reported by checkpath.
> > > >
> > > > do loop with the conditional expression set to a constant
> > > > value of zero (0).This creates a loop that
> > > > will execute exactly one time.This is a coding idiom that
> > > > allows a multi-line macro to be used anywhere
> > > > that a single statement can be used.
> > > >
> > > > So, enclose `gb_loopback_stats_attrs` macro in do - while (0) to
> > > > fix checkpath error
> > > >
> > > > Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx>
> > > > ---
> > > This breaks the build.  You need to compile the code before sending a
> > > patch.
> > >
> > > regards,
> > > dan carpenter
> >
> > I see, I thought building the file only enough. appreciate your feedback.
> The outreachy tutorial explains how to compile everything in a
> subdirectory.
>
> julia


Thanks Julia, I will check it.

Menna