Re: [PATCH] hwspinlock: omap: drop of_match_ptr for ID table

[Baolin Wang]

On 3/11/2023 7:14 PM, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
>    drivers/hwspinlock/omap_hwspinlock.c:164:34: error: ‘omap_hwspinlock_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

> ---
>   drivers/hwspinlock/omap_hwspinlock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
> index 1fb3a2550e29..dfe82952671b 100644
> --- a/drivers/hwspinlock/omap_hwspinlock.c
> +++ b/drivers/hwspinlock/omap_hwspinlock.c
> @@ -174,7 +174,7 @@ static struct platform_driver omap_hwspinlock_driver = {
>   	.remove		= omap_hwspinlock_remove,
>   	.driver		= {
>   		.name	= "omap_hwspinlock",
> -		.of_match_table = of_match_ptr(omap_hwspinlock_of_match),
> +		.of_match_table = omap_hwspinlock_of_match,
>   	},
>   };
>