Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command

[Chao Yu]

On 2023/3/10 22:02, Christoph Hellwig wrote:
> > -	/* If command type is WRITE or DISCARD, set bitmap as dirty */
> > -	if (ufshpb_is_write_or_discard(cmd)) {
> > +	/* If command type is WRITE, set bitmap as dirty */
> > +	if (op_is_write(req_op(scsi_cmd_to_rq(cmd)))) {
>
> Umm, a driver has absolutely no business poking into the UNMAP
> payload.   Someone needs to fix the UFS driver first to not do this.

IIUC，originally, HPB driver tries to lookup LBA range{,s} from WRITE/DISCARD
request, and will dirty mapped HPB regions based on LBA range{,s}, do you mean
HPB driver should not parse DISCARD request?