Re: [PATCH 3/3] drm/lima: add show_fdinfo for drm usage stats

[Qiang Yu]

On Mon, Mar 13, 2023 at 7:31 AM Erico Nunes <nunes.erico@xxxxxxxxx> wrote:
>
> This exposes an accumulated active time per client via the fdinfo
> infrastructure per execution engine, following
> Documentation/gpu/drm-usage-stats.rst.
> In lima, the exposed execution engines are gp and pp.
>
> Signed-off-by: Erico Nunes <nunes.erico@xxxxxxxxx>
> ---
>  drivers/gpu/drm/lima/lima_drv.c | 31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_drv.c b/drivers/gpu/drm/lima/lima_drv.c
> index d23c0b77a252..c044a31493a4 100644
> --- a/drivers/gpu/drm/lima/lima_drv.c
> +++ b/drivers/gpu/drm/lima/lima_drv.c
> @@ -261,7 +261,36 @@ static const struct drm_ioctl_desc lima_drm_driver_ioctls[] = {
>         DRM_IOCTL_DEF_DRV(LIMA_CTX_FREE, lima_ioctl_ctx_free, DRM_RENDER_ALLOW),
>  };
>
> -DEFINE_DRM_GEM_FOPS(lima_drm_driver_fops);
> +static void lima_drm_driver_show_fdinfo(struct seq_file *m, struct file *filp)
> +{
> +       struct drm_file *file = filp->private_data;
> +       struct drm_device *dev = file->minor->dev;
> +       struct lima_device *ldev = dev->dev_private;
Can use to_lima_dev().

> +       struct lima_drm_priv *priv = file->driver_priv;
> +       struct lima_ctx_mgr *ctx_mgr = &priv->ctx_mgr;
> +       u64 usage[lima_pipe_num];
> +
> +       lima_ctx_mgr_usage(ctx_mgr, usage);
> +
> +       /*
> +        * For a description of the text output format used here, see
> +        * Documentation/gpu/drm-usage-stats.rst.
> +        */
> +       seq_printf(m, "drm-driver:\t%s\n", dev->driver->name);
> +       seq_printf(m, "drm-client-id:\t%u\n", priv->id);
> +       for (int i = 0; i < lima_pipe_num; i++) {
> +               struct lima_sched_pipe *pipe = &ldev->pipe[i];
> +               struct drm_gpu_scheduler *sched = &pipe->base;
> +
> +               seq_printf(m, "drm-engine-%s:\t%llu ns\n", sched->name, usage[i]);
> +       }
> +}
> +
> +static const struct file_operations lima_drm_driver_fops = {
> +       .owner = THIS_MODULE,
> +       DRM_GEM_FOPS,
> +       .show_fdinfo = lima_drm_driver_show_fdinfo,
> +};
>
>  /*
>   * Changelog:
> --
> 2.39.2
>