Re: [PATCH 1/8] arm64: dts: qcom: sda660-inforce: correct key node name

From: Konrad Dybcio
Date: Mon Mar 13 2023 - 04:50:02 EST




On 12.03.2023 19:36, Krzysztof Kozlowski wrote:
> gpio-key bindings expect children to be named with generic prefix:
>
> sda660-inforce-ifc6560.dtb: gpio-keys: 'volup' does not match any of the regexes: ...
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> index 7c81918eee66..7459525d9982 100644
> --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> @@ -29,7 +29,7 @@ chosen {
> gpio-keys {
> compatible = "gpio-keys";
>
> - volup {
> + key-volup {
> label = "Volume Up";
> gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
> linux,code = <KEY_VOLUMEUP>;