RE: [PATCH v1 2/3] dt-bindings: soc: meta: Add meta cld driver bindings

[Delphine_CC_Chiu/WYHQ/Wiwynn]

Hi Krzysztof,

Thanks for your comment.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, January 17, 2023 6:50 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: garnermic@xxxxxx; Derek Kiernan <derek.kiernan@xxxxxxxxxx>; Dragan
> Cvetic <dragan.cvetic@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Greg
> Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Stanislav Jakubek
> <stano.jakubek@xxxxxxxxx>; Daniel Palmer <daniel@xxxxxxxx>; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; Samuel Holland <samuel@xxxxxxxxxxxx>;
> linux-i2c@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 2/3] dt-bindings: soc: meta: Add meta cld driver
> bindings
> 
>   Security Reminder: Please be aware that this email is sent by an external
> sender.
> 
> On 17/01/2023 10:44, Delphine CC Chiu wrote:
> > Add a device tree bindings for Meta control logic device.
> 
> Subject: drop second/last, redundant "bindings". The "dt-bindings"
> prefix is already stating that these are bindings.

We will remove the bindings from the subject.

> 
> Subject: Drop "driver"

We will revise the subject.

> 
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> > ---
> >  .../misc/meta,control-logic-device.txt        | 37 +++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/meta,control-logic-device.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/misc/meta,control-logic-device.txt
> > b/Documentation/devicetree/bindings/misc/meta,control-logic-device.txt
> > new file mode 100644
> > index 000000000000..e966368e2fd6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/meta,control-logic-device
> > +++ .txt
> 
> New bindings only in DT schema format. Start
> Documentation/devicetree/bindings/writing-schema.rst,
> example-schema.yaml and other docs.

We will rewrite the binding document following the schema.

> 
> 
> 
> Best regards,
> Krzysztof

Thanks,
Delphine