Re: [PATCH 2/8] arm64: dts: qcom: sc7280-herobrine-villager: correct trackpad supply

From: Konrad Dybcio
Date: Mon Mar 13 2023 - 04:51:35 EST




On 12.03.2023 19:36, Krzysztof Kozlowski wrote:
> The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other
> Herobrine boards which use elan,ekth3000 with valid VCC:
>
> sc7280-herobrine-villager-r1-lte.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: ee2a62116015 ("arm64: dts: qcom: sc7280: Add device tree for herobrine villager")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---


Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
> index 818d4046d2c7..38c8a3679fcb 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
> @@ -33,7 +33,7 @@ trackpad: trackpad@2c {
> interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>
> hid-descr-addr = <0x20>;
> - vcc-supply = <&pp3300_z1>;
> + vdd-supply = <&pp3300_z1>;
>
> wakeup-source;
> };