RE: [PATCH] crypto: tls - Use data directly in completion function

[Meenakshi Aggarwal]

Please don't review the patch, sent by mistake.

Thanks,
Meenakshi

> -----Original Message-----
> From: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
> Sent: Friday, March 10, 2023 3:59 PM
> To: Varun Sethi <V.Sethi@xxxxxxx>; Pankaj Gupta <pankaj.gupta@xxxxxxx>;
> Gaurav Jain <gaurav.jain@xxxxxxx>; herbert@xxxxxxxxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
> Subject: [PATCH] crypto: tls - Use data directly in completion function
> 
> From: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
> 
> Facing build error in building tls
> error: passing argument 3 of ?ahash_request_set_callback?
> from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> Issue introduced after changing prototype of "crypto_completion_t"
> function pointer in include/linux/crypto.h, conversion of completion function of
> tls was missed.
> 
> Changes are done to use data directly in completion function of tls.
> 
> Fixes: 255e48eb1768 ("crypto: api - Use data directly in completion function")
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@xxxxxxx>
> ---
>  crypto/tls.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/crypto/tls.c b/crypto/tls.c index e04f3b450b43..f16810238d1a
> 100644
> --- a/crypto/tls.c
> +++ b/crypto/tls.c
> @@ -1,6 +1,6 @@
>  /*
>   * Copyright 2013 Freescale
> - * Copyright 2017 NXP
> + * Copyright 2017, 2023 NXP
>   *
>   * This program is free software; you can redistribute it and/or modify it
>   * under the terms of the GNU General Public License as published by the Free
> @@ -50,9 +50,9 @@ struct async_op {
>  	int err;
>  };
> 
> -static void tls_async_op_done(struct crypto_async_request *req, int err)
> +static void tls_async_op_done(void *data, int err)
>  {
> -	struct async_op *areq = req->data;
> +	struct async_op *areq = data;
> 
>  	if (err == -EINPROGRESS)
>  		return;
> --
> 2.25.1