Re: [PATCH] pinctrl: sx150x: drop of_match_ptr for ID table

From: Linus Walleij
Date: Mon Mar 13 2023 - 06:18:46 EST

Next message: Michal Simek: "Re: [PATCH] soc: xilinx: Use of_property_present() for testing DT property presence"
Previous message: Andre Przywara: "Re: [PATCH] pinctrl: Use of_property_present() for testing DT property presence"
In reply to: Krzysztof Kozlowski: "[PATCH] pinctrl: sx150x: drop of_match_ptr for ID table"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Mar 12, 2023 at 2:27 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:

> The driver will match mostly by DT table (even thought there is regular
> ID table) so there is little benefit in of_match_ptr (this also allows
> ACPI matching via PRP0001, even though it might not be relevant here).
> This also fixes !CONFIG_OF error:
>
> drivers/pinctrl/pinctrl-sx150x.c:833:34: error: ‘sx150x_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Patch applied!

Yours,
Linus Walleij

Next message: Michal Simek: "Re: [PATCH] soc: xilinx: Use of_property_present() for testing DT property presence"
Previous message: Andre Przywara: "Re: [PATCH] pinctrl: Use of_property_present() for testing DT property presence"
In reply to: Krzysztof Kozlowski: "[PATCH] pinctrl: sx150x: drop of_match_ptr for ID table"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]