Re: [PATCH v2 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups

From: Yan Zhao
Date: Mon Mar 13 2023 - 06:22:41 EST


On Fri, Mar 10, 2023 at 04:22:31PM -0800, Sean Christopherson wrote:
> Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's
> page-track APIs to provide a leaner and cleaner interface. The motivation
> for this series is to (significantly) reduce the number of KVM APIs that
> KVMGT uses, with a long-term goal of making all kvm_host.h headers
> KVM-internal.
>
> As was the case in v1, tThe KVMGT changes are compile tested only.
>
> Based on "git://git.kernel.org/pub/scm/virt/kvm/kvm.git next".
>
> v2:
> - Reuse vgpu_lock to protect gfn hash instead of introducing a new (and
> buggy) mutext. [Yan]
> - Remove a spurious return from kvm_page_track_init(). [Yan]
> - Take @kvm directly in the inner __kvm_page_track_write(). [Yan]
> - Delete the gfn sanity check that relies on kvm_is_visible_gfn() instead
> of providing a dedicated interface. [Yan]
>
> base-commit: 45dd9bc75d9adc9483f0c7d662ba6e73ed698a0b
> --
Thanks for the update!
It passed basic tests (gvt in a single vm) at my side.
Will do detailed review tomorrow.

Thanks
Yan