Re: Patch for a overwriting/corruption of the file system

[Greg KH]

On Mon, Mar 13, 2023 at 03:54:55PM +0530, Kirtikumar Anandrao Ramchandani wrote:
> Seems like again it got rejected. I am sending it in the body if it works:
> 
> >From 839cae91705e044b49397590f2d85a5dd289f0c5 Mon Sep 17 00:00:00 2001
> From: KirtiRamchandani <kirtar15502@xxxxxxxxx>
> Date: Mon, 13 Mar 2023 15:05:08 +0530
> Subject: [PATCH] Fix bug in affs_rename() function. The `affs_rename()`
>  function in the AFFS filesystem has a bug that can cause the `retval`
>  variable to be overwritten before it is used. Specifically, the function
>  assigns `retval` a value in two separate code blocks, but then only checks
>  its value in one of those blocks. This commit fixes the bug by ensuring
> that
>  `retval` is properly checked in both code blocks.
> 
> Signed-off-by: KirtiRamchandani <kirtar15502@xxxxxxxxx>
> ---
>  namei.c | 4++++--
>  1 file changed, 4 insertions(+), 2 deletion(-)
> 
> diff --git a/fs/affs/namei.c b/fs/affs/namei.c
> index d1084e5..a54c700 100644
> --- a/fs/affs/namei.c
> +++ b/fs/affs/namei.c
> @@ -488,7 +488,8 @@ affs_xrename(struct inode *old_dir, struct dentry
> *old_dentry,
>         affs_lock_dir(new_dir);
>         retval = affs_insert_hash(new_dir, bh_old);
>         affs_unlock_dir(new_dir);
> -
> +       if (retval)
> +               goto done;

The patch is corrupted and can not be applied.

Here's the response from my patch bot.  Please read over the
documentation and try to submit it properly like any other normal
change.

------------


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot