Re: [PATCH 1/1] regulator: pca9450: Fix BUCK2 enable_mask

[Alexander Stein]

Hi Frieder,

thanks for your comments.

Am Montag, 13. März 2023, 14:46:08 CET schrieb Frieder Schrempf:
> On 10.03.23 10:28, Alexander Stein wrote:
> > This fixes a copy & paste error.
> 
> I would mention here, that this doesn't contain any functional changes
> as BUCK1_ENMODE_MASK is equal to BUCK2_ENMODE_MASK.

That's a good idea.

> > Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> > Originally-from: Robin Gong <yibin.gong@xxxxxxx>
> > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > ---
> > This diff is extracted from a downstream commit authored by Robin Gong.
> > I'm not sure if adding Originally-from: is enough here or I do have to
> > change From: as well.
> 
> I never heard of "Originally-from:". Does this tag exist? Is it
> documented somewhere?

Well, it's not documented, but it pops up occasionally in some commits, e.g.
3fb906e7fabbb ("cgroup/cpuset: Don't filter offline CPUs in 
cpuset_cpus_allowed() for top cpuset tasks")
I might be something only some maintainers accept though.

> I think that your tooling (git format-patch) should add a From: tag
> automatically if you correctly pick up a patch from someone else.

Well, it's not exactly cherry-picked, but extracted from an existing commit 
[1], so that's maybe why my name has been put into From: while extracting.
As the diff in this patch is not exactly the same as from the origin, I did 
not want to put Robin Gong into Signed-off-by. And I think having an author in 
From: but not in Signed-off-by: tag should not happen.
Searching how I can still give credit I found Originally-from. If there is a 
better way to handle this, I'm ready to adapt to that.

Best regards,
Alexander

[1] https://github.com/Freescale/linux-fslc/commit/
fe6b4f7a23a79637c6fb182fb1ea9136d953e3f7

> Other than these formal issues the change itself looks good to me.
> 
> >  drivers/regulator/pca9450-regulator.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/regulator/pca9450-regulator.c
> > b/drivers/regulator/pca9450-regulator.c index c84d95b11e9c..544e741f7108
> > 100644
> > --- a/drivers/regulator/pca9450-regulator.c
> > +++ b/drivers/regulator/pca9450-regulator.c
> > @@ -265,7 +265,7 @@ static const struct pca9450_regulator_desc
> > pca9450a_regulators[] = {> 
> >  			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
> >  			.vsel_mask = BUCK2OUT_DVS0_MASK,
> >  			.enable_reg = PCA9450_REG_BUCK2CTRL,
> > 
> > -			.enable_mask = BUCK1_ENMODE_MASK,
> > +			.enable_mask = BUCK2_ENMODE_MASK,
> > 
> >  			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
> >  			.ramp_reg = PCA9450_REG_BUCK2CTRL,
> >  			.ramp_mask = BUCK2_RAMP_MASK,
> > 
> > @@ -509,7 +509,7 @@ static const struct pca9450_regulator_desc
> > pca9450bc_regulators[] = {> 
> >  			.vsel_reg = PCA9450_REG_BUCK2OUT_DVS0,
> >  			.vsel_mask = BUCK2OUT_DVS0_MASK,
> >  			.enable_reg = PCA9450_REG_BUCK2CTRL,
> > 
> > -			.enable_mask = BUCK1_ENMODE_MASK,
> > +			.enable_mask = BUCK2_ENMODE_MASK,
> > 
> >  			.enable_val = BUCK_ENMODE_ONREQ_STBYREQ,
> >  			.ramp_reg = PCA9450_REG_BUCK2CTRL,
> >  			.ramp_mask = BUCK2_RAMP_MASK,


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/