Re: [PATCH 3/8] arm64: dts: qcom: sc7180-trogdor-lazor: correct trackpad supply
From: Doug Anderson
Date: Mon Mar 13 2023 - 10:38:04 EST
Hi,
On Sun, Mar 12, 2023 at 11:36 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> The hid-over-i2c takes VDD, not VCC supply. Fix copy-pasta from other
> boards which use elan,ekth3000 with valid VCC:
>
> sc7180-trogdor-lazor-limozeen-nots-r4.dtb: trackpad@2c: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: 2c26adb8dbab ("arm64: dts: qcom: Add sc7180-lazor-limozeen skus")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts
> index 850776c5323d..70d5a7aa8873 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dts
> @@ -26,7 +26,7 @@ trackpad: trackpad@2c {
> interrupt-parent = <&tlmm>;
> interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
>
> - vcc-supply = <&pp3300_fp_tp>;
> + vdd-supply = <&pp3300_fp_tp>;
Luckily it didn't matter since this regulator is always on, but good
to have things described properly.
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>