Re: [PATCH] nfs: use vfs setgid helper

From: Christian Brauner
Date: Mon Mar 13 2023 - 11:31:36 EST


On Mon, Mar 13, 2023 at 08:23:49AM -0700, Christoph Hellwig wrote:
> On Mon, Mar 13, 2023 at 02:25:34PM +0100, Christian Brauner wrote:
> > +#include "../internal.h"
>
> > + if (setattr_should_drop_sgid(&nop_mnt_idmap, inode))
>
> It setattr_should_drop_sgid is used by file systems, it should not be in
> internal.h.

Good catch. I accidently didn't move it into include/linux/fs.h
with setattr_should_drop_suidgid(). Let me resend. Thanks for
catching this...