Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void

[Laurentiu Tudor]

On 3/11/2023 12:41 AM, Uwe Kleine-König wrote:
> Hello,
>
> many bus remove functions return an integer which is a historic
> misdesign that makes driver authors assume that there is some kind of
> error handling in the upper layers. This is wrong however and returning
> and error code only yields an error message.
>
> This series improves the fsl-mc bus by changing the remove callback to
> return no value instead. As a preparation all drivers are changed to
> return zero before so that they don't trigger the error message.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (6):
>    bus: fsl-mc: Only warn once about errors on device unbind
>    bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()
>    bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong
>      condition
>    bus: fsl-mc: fsl-mc-allocator: Improve error reporting
>    soc: fsl: dpio: Suppress duplicated error reporting on device remove
>    bus: fsl-mc: Make remove function return void

Thanks for the series, Uwe. Did a quick boot test with ACPI, so:

Reviewed-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
Tested-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>