RE: [PATCH 1/1] x86/vdso: use the right GDT_ENTRY_CPUNODE for 32-bit getcpu() on 64-bit kernel

[Li, Xin3]

> > +#ifndef BUILD_VDSO32_64
> >  #define GDT_ENTRY_CPUNODE		28
> > +#else
> > +#define GDT_ENTRY_CPUNODE		15
> > +#endif
> 
> Isn't this kinda a hack?
> 
> First, it means that we'll now have two duplicate versions of this:
> 
> 	#define GDT_ENTRY_CPUNODE		15
> 
> in the same file.
> 
> Second, if any other users of fake_32bit_build.h for the VDSO show up, they'll
> need a similar #ifdef.
> 
> I think I'd much rather if we define all of the GDT_ENTRY_* macros in
> *one* place, then make that *one* place depend on BUILD_VDSO32_64.

Sounds a better way, let me try.

> Also, about the *silent* failure...  Do we not have a selftest for this somewhere?

When lsl is used, we should check ZF which indicates whether the segment limit
is loaded successfully.  Seems we need to refactor vdso_read_cpunode() a bit.

  Xin