Re: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt

[Lars-Peter Clausen]

On 3/13/23 10:02, Jisheng Zhang wrote:
> The dma framework will calculate the dma channels chancnt, setting it
> outself is wrong.

s/outself/ourself/

Looks good otherwise, thanks.

Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---
>   drivers/dma/dma-axi-dmac.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index a812b9b00e6b..fc7cdad37161 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev)
>   	dma_dev->device_terminate_all = axi_dmac_terminate_all;
>   	dma_dev->device_synchronize = axi_dmac_synchronize;
>   	dma_dev->dev = &pdev->dev;
> -	dma_dev->chancnt = 1;
>   	dma_dev->src_addr_widths = BIT(dmac->chan.src_width);
>   	dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width);
>   	dma_dev->directions = BIT(dmac->chan.direction);