Re: [PATCH 2/3] arm64: dts: renesas: rzg2l-smarc: Add OV5645 node

From: Lad, Prabhakar
Date: Mon Mar 13 2023 - 16:51:49 EST


Hi Geert,

On Wed, Mar 8, 2023 at 10:59 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Mar 06, 2023 at 08:27:19PM +0100, Geert Uytterhoeven wrote:
> > Hi Prabhakar,
> >
> > On Thu, Feb 16, 2023 at 6:57 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > >
> > > OV5645 sensor can be connected to the CN1 connector on the
> > > carrier board. This patch adds the ov5645 node under i2c0 node.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dts
> > > @@ -6,6 +6,10 @@
> > > */
> > >
> > > /dts-v1/;
> > > +
> > > +/* comment the #define statement if OV5645 is not connected to CN1 */
> > > +#define CAM_INTERFACE_OV5645 1
> >
> > I believe the camera is optional ("can be connector" above).
> > So shouldn't this be commented out by default?
>
> Even better, could you turn this into a DT overlay ?
>
Please let me know your thoughts on this.

> > The rest LGTM, so with the above sorted out:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
Cheers,
Prabhakar