Re: [PATCH net] net: ethernet: fix use after free bug in ns83820_remove_one due to race condition

From: Jakub Kicinski
Date: Mon Mar 13 2023 - 19:26:36 EST


On Thu, 9 Mar 2023 17:42:31 +0800 Zheng Wang wrote:
> + cancel_work_sync(&dev->tq_refill);
> ns83820_disable_interrupts(dev); /* paranoia */
>
> unregister_netdev(ndev);

Canceling the work before unregister can't work.
Please take a closer look, the work to refill a ring should be
canceled when the ring itself is dismantled.