Re: [PATCH v4 04/16] perf kvm: Use subtraction for comparison metrics

From: Leo Yan
Date: Mon Mar 13 2023 - 20:27:06 EST


On Mon, Mar 13, 2023 at 02:58:22PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 13, 2023 at 07:40:06PM +0800, Leo Yan escreveu:
> > Currently the metrics comparison uses greater operator (>), it returns
> > the boolean value (0 or 1).
> >
> > This patch changes to use subtraction as comparison result, which can
> > be used by histograms sorting. Since the subtraction result is u64
> > type, we change the function return type from int to int64_t to avoid
> > overflow.
>
> Not building at his point in the series:

Sorry for this!

I can reproduce the building failure, will check patches compilation one
by one and send out new patch set in today's later time.

Thanks,
Leo