Re: [PATCH v2] bus: imx-weim: fix branch condition evaluates to a garbage value

From: Shawn Guo
Date: Mon Mar 13 2023 - 23:45:14 EST


On Mon, Mar 06, 2023 at 04:25:26PM +0300, Ivan Bornyakov wrote:
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
> Signed-off-by: Ivan Bornyakov <i.bornyakov@xxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>

Ok, picked this version up instead.