Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0

From: Shawn Guo
Date: Tue Mar 14 2023 - 03:28:45 EST


On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@xxxxxxx>
>
> This reduces power consumption in system suspend by about 10%.

Is there any other impact than this nice power gain? Otherwise,
I would wonder why the quirk was enabled in the first place.

Shawn

>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@xxxxxxx>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 0b4b49fa1392a..f557632f574fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
> #address-cells = <1>;
> #size-cells = <0>;
> dr_mode = "otg";
> - snps,dis_u3_susphy_quirk;
> usb-role-switch;
> status = "okay";
>
> --
> 2.30.2
>