Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table

[Hans Verkuil]

On 13/03/2023 23:01, Guenter Roeck wrote:
> On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote:
>> The driver can match only via the DT table so the table should be always
>> used and the of_match_ptr does not have any sense (this also allows ACPI
>> matching via PRP0001, even though it might not be relevant here).
>>
>>   drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> FWIW: There is also
> https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@xxxxxxxxxxxx/

I superseded that patch in patchwork in favor of this patch since this is part of
a larger series.

Krzysztof, please let me know if you will take this series yourself or want me to
make a PR for it.

Regards,

	Hans

> 
> The lack of ACPI support is a real problem and very relevant.
> 
> Guenter
> 
>> ---
>>  drivers/media/cec/i2c/ch7322.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
>> index 34fad7123704..3c6e6496a001 100644
>> --- a/drivers/media/cec/i2c/ch7322.c
>> +++ b/drivers/media/cec/i2c/ch7322.c
>> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
>>  static struct i2c_driver ch7322_i2c_driver = {
>>  	.driver = {
>>  		.name = "ch7322",
>> -		.of_match_table = of_match_ptr(ch7322_of_match),
>> +		.of_match_table = ch7322_of_match,
>>  	},
>>  	.probe_new	= ch7322_probe,
>>  	.remove		= ch7322_remove,