Re: [PATCH v2 15/21] dt-bindings: pinctrl: {mediatek,ralink}: fix formatting

From: Rob Herring
Date: Tue Mar 14 2023 - 10:10:37 EST



On Mon, 13 Mar 2023 23:59:15 +0300, arinc9.unal@xxxxxxxxx wrote:
> From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
>
> Change the style of description properties to plain style where there's no
> need to preserve the line endings, and vice versa.
>
> Fit the schemas to 80 columns for each line.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 22 +++---
> .../pinctrl/mediatek,mt6779-pinctrl.yaml | 33 +++++----
> .../pinctrl/mediatek,mt6795-pinctrl.yaml | 33 +++++----
> .../pinctrl/mediatek,mt7620-pinctrl.yaml | 2 +-
> .../pinctrl/mediatek,mt7621-pinctrl.yaml | 2 +-
> .../pinctrl/mediatek,mt7622-pinctrl.yaml | 26 +++----
> .../pinctrl/mediatek,mt7981-pinctrl.yaml | 33 +++++----
> .../pinctrl/mediatek,mt7986-pinctrl.yaml | 68 ++++++++---------
> .../pinctrl/mediatek,mt8183-pinctrl.yaml | 26 ++++---
> .../pinctrl/mediatek,mt8186-pinctrl.yaml | 47 ++++++------
> .../pinctrl/mediatek,mt8188-pinctrl.yaml | 74 ++++++++++---------
> .../pinctrl/mediatek,mt8192-pinctrl.yaml | 47 ++++++------
> .../pinctrl/mediatek,mt8195-pinctrl.yaml | 41 +++++-----
> .../pinctrl/mediatek,mt8365-pinctrl.yaml | 28 +++----
> .../pinctrl/ralink,rt2880-pinctrl.yaml | 2 +-
> .../pinctrl/ralink,rt305x-pinctrl.yaml | 2 +-
> .../pinctrl/ralink,rt3883-pinctrl.yaml | 2 +-
> 17 files changed, 254 insertions(+), 234 deletions(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:103:16: [warning] wrong indentation: expected 14 but found 15 (indentation)
./Documentation/devicetree/bindings/pinctrl/mediatek,mt6795-pinctrl.yaml:113:16: [warning] wrong indentation: expected 14 but found 15 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230313205921.35342-16-arinc.unal@xxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.