Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c

[Juergen Gross]

On 14.03.23 15:33, Jan Beulich wrote:
> On 14.03.2023 15:27, Juergen Gross wrote:
> > V2:
> > - add const, use unsigned int for loop counters (Roger Pau Monné)
>
> Hmm, ...
>
> > --- a/drivers/block/xen-blkback/blkback.c
> > +++ b/drivers/block/xen-blkback/blkback.c
> > @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio)
> >   	bio_put(bio);
> >   }
> >   
> > +static void blkif_get_x86_32_req(struct blkif_request *dst,
> > +				 const struct blkif_x86_32_request *src)
> > +{
> > +	unsigned int i, n;
>
> ... here you did, but ...
>
> > +static void blkif_get_x86_64_req(struct blkif_request *dst,
> > +				 struct blkif_x86_64_request *src)
> > +{
> > +	int i, n;
>
> ... what about these?

Oh, indeed. I could say Roger commented only on blkif_get_x86_32_req(), but this
would be a rather lame excuse. ;-)

I'll resend that last patch.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature