Re: [PATCH 3/3] pinctrl: s32cc: embed generic struct pingroup and pinfunction

[Andy Shevchenko]

On Tue, Mar 14, 2023 at 3:47 PM Chester Lin <clin@xxxxxxxx> wrote:
>
> Use generic data structure to describe pin control functions and groups in
> S32 SoC family and drop duplicated struct members.

...

>  struct s32_pmx_func {
> -       const char *name;
> -       const char **groups;
> -       unsigned int num_groups;
> +       struct pinfunction data;
>  };

Since you have a single driver with this, just kill the entire custom
structure.

The way it's done in the pinctrl-intel.c is due to dozens of drivers
sharing the same data type and hence converting that will provoke
quite a noise for no benefit. Here it's not the case, so just kill it.

-- 
With Best Regards,
Andy Shevchenko